chore(router): provide more debug info when detecting an illegal job sequence #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
requested review from
lvrach,
fracasula,
cisse21,
BonapartePC,
achettyiitr and
Sidddddarth
atzoum
force-pushed
the
chore.userOrdering
branch
from
9ea60b5
to
d944202
Compare
atzoum
force-pushed
the
chore.userOrdering
branch
2 times, most recently
from
9214645
to
dd6143e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
+ Coverage 69.04% 69.09% +0.05%
==========================================
Files 347 347
Lines 51692 51734 +42
==========================================
+ Hits 35691 35746 +55
+ Misses 13709 13688 -21
- Partials 2292 2300 +8
☔ View full report in Codecov by Sentry. |
atzoum
force-pushed
the
chore.userOrdering
branch
4 times, most recently
from
a907083
to
01ef697
Compare
atzoum
force-pushed
the
chore.userOrdering
branch
from
01ef697
to
9fe5ecb
Compare
Sidddddarth
approved these changes
Aug 25, 2023
fracasula
reviewed
Aug 25, 2023
Comment on lines
+156
to
+160
| defer func() { | ||
| if r := recover(); r != nil { | ||
| res = fmt.Sprintf("panic in EventOrderDebugInfo: %v", r) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Is this going to catch the panic and not propagate it anymore? So the next time we got an out of order rudder-server won't crash? I thought you would save the data and re-issue the panic.
There was a problem hiding this comment.
My bad, this is for the local panic.
fracasula
approved these changes
Aug 25, 2023
achettyiitr
pushed a commit
that referenced
this pull request
Aug 28, 2023
…sequence (#3787) Adding information about sequence of job statuses recorded in database to help debug job sequence issues.
achettyiitr
pushed a commit
that referenced
this pull request
Aug 28, 2023
…sequence (#3787) Adding information about sequence of job statuses recorded in database to help debug job sequence issues.
This was referenced Aug 28, 2023
Merged
fracasula
pushed a commit
that referenced
this pull request
Sep 12, 2023
* chore(router): provide more debug info when detecting an illegal job sequence (#3787) Adding information about sequence of job statuses recorded in database to help debug job sequence issues. * chore: some more changes * chore: fix test * chore: fix test * chore: fix test * chore: some more changes * chore: tests fix --------- Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding information about sequence of job statuses recorded in database to help debug job sequence issues.
Linear Ticket
Link
Security