chore: router_response_counts stat now shows if it's a retry attempt #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
reviewed
Aug 28, 2023
lvrach
approved these changes
Aug 28, 2023
using `strconv.FormatBool` instead of `fmt.Sprint` Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
cisse21
approved these changes
Aug 28, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3799 +/- ##
==========================================
+ Coverage 68.97% 69.00% +0.03%
==========================================
Files 349 349
Lines 51886 51887 +1
==========================================
+ Hits 35786 35804 +18
+ Misses 13798 13777 -21
- Partials 2302 2306 +4
☔ View full report in Codecov by Sentry. |
This was referenced Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
router_response_countsstat now tell if an attempt is a retry(true/false).Checks if
attemptNum > 1.Linear Ticket
adding retry flag to
router_response_countsSecurity