Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not delete staging files when opted for rudderstorge during archival #3801

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 28, 2023

Description

  • Do not delete staging files during archival if opted for rudder storage, since there is already a retention policy set for the bucket.
  • Also, by doing so, we will have an option to re-sync the data. We have seen a couple of cases, where customers opted for the rudder storage option and backups were not enabled.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: +0.12% 🎉

Comparison is base (ec07777) 68.99% compared to head (2766039) 69.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3801      +/-   ##
==========================================
+ Coverage   68.99%   69.12%   +0.12%     
==========================================
  Files         349      349              
  Lines       51887    51867      -20     
==========================================
+ Hits        35798    35851      +53     
+ Misses      13782    13714      -68     
+ Partials     2307     2302       -5     
Files Changed Coverage Δ
warehouse/archive/archiver.go 68.02% <70.00%> (+0.76%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 3dff32d into master Aug 29, 2023
40 checks passed
@achettyiitr achettyiitr deleted the fix.undo-deleting-staging-files-archival branch August 29, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants