chore: add gw failure stats #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
force-pushed
the
chore.addGWFailureStats
branch
from
6ae3647
to
2fcc49f
Compare
atzoum
reviewed
Aug 30, 2023
| @@ -36,10 +36,26 @@ func (gw *Handle) writeKeyAuth(delegate http.HandlerFunc) http.HandlerFunc { | |||
| } | |||
| arctx := gw.authRequestContextForWriteKey(writeKey) | |||
| if arctx == nil { | |||
| stat := gwstats.SourceStat{ | |||
There was a problem hiding this comment.
can we handle this stat centrally, eg. similar to what gw#handleHttpError does?
There was a problem hiding this comment.
Addressed this... let me know if this looks good
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3809 +/- ##
==========================================
+ Coverage 69.06% 69.19% +0.12%
==========================================
Files 349 349
Lines 51899 51947 +48
==========================================
+ Hits 35845 35944 +99
+ Misses 13748 13700 -48
+ Partials 2306 2303 -3
☔ View full report in Codecov by Sentry. |
cisse21
force-pushed
the
chore.addGWFailureStats
branch
from
2fcc49f
to
bfec796
Compare
lvrach
approved these changes
Aug 30, 2023
cisse21
force-pushed
the
chore.addGWFailureStats
branch
from
bfec796
to
3d804b9
Compare
cisse21
force-pushed
the
chore.addGWFailureStats
branch
from
3d804b9
to
6b08d64
Compare
Sidddddarth
force-pushed
the
chore.addGWFailureStats
branch
from
6b08d64
to
9b56bc8
Compare
…r-server into chore.addGWFailureStats
Sidddddarth
approved these changes
Sep 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add stats for failures at GW
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-203/release-1130-fixes
Security