Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increased postgres cpu usage after switching to a single get jobs query #3812

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Aug 30, 2023

Description

Switching back to multiple queries in router, batchrouter & stash loops, while keeping jobsdb refactoring introduced by #3742.

JobsDB changes:

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 79.48% and project coverage change: -0.08% ⚠️

Comparison is base (96588bb) 69.13% compared to head (8c5ba37) 69.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3812      +/-   ##
==========================================
- Coverage   69.13%   69.06%   -0.08%     
==========================================
  Files         349      349              
  Lines       51947    52023      +76     
==========================================
+ Hits        35915    35928      +13     
- Misses      13730    13784      +54     
- Partials     2302     2311       +9     
Files Changed Coverage Δ
processor/stash/stash.go 54.57% <66.66%> (+2.05%) ⬆️
jobsdb/jobsdb.go 72.44% <80.28%> (-0.14%) ⬇️
router/batchrouter/handle.go 63.21% <82.35%> (+0.29%) ⬆️
jobsdb/queued_db_request.go 90.00% <100.00%> (ø)
router/internal/jobiterator/jobiterator.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum force-pushed the fix.singleQuery branch 2 times, most recently from 0fdd5db to 09ceaa0 Compare September 1, 2023 10:42
@atzoum atzoum merged commit e4a65f3 into master Sep 4, 2023
35 checks passed
@atzoum atzoum deleted the fix.singleQuery branch September 4, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants