Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: populate context with validation errors when context is nil #3815

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

Jayachand
Copy link
Contributor

@Jayachand Jayachand commented Aug 31, 2023

Description

enrich tracking plan validation errors when context is nil or not present

Linear Ticket

https://linear.app/rudderstack/issue/DAT-312/handle-scenarios-where-context-is-undefined-or-is-not-present-in-the

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

processor/trackingplan.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (fdfb4f6) 69.06% compared to head (2e49a95) 69.04%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3815      +/-   ##
==========================================
- Coverage   69.06%   69.04%   -0.03%     
==========================================
  Files         349      349              
  Lines       51899    51909      +10     
==========================================
- Hits        35845    35841       -4     
- Misses      13748    13764      +16     
+ Partials     2306     2304       -2     
Files Changed Coverage Δ
processor/trackingplan.go 57.03% <100.00%> (+3.64%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jayachand Jayachand merged commit dcb6a15 into master Sep 4, 2023
37 checks passed
@Jayachand Jayachand deleted the chore.tpEventContextAddition branch September 4, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants