-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use single query for getting jobs #3820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2be669b
to
6279a85
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3820 +/- ##
==========================================
- Coverage 68.92% 68.68% -0.25%
==========================================
Files 352 352
Lines 52604 52677 +73
==========================================
- Hits 36259 36181 -78
- Misses 14015 14174 +159
+ Partials 2330 2322 -8
☔ View full report in Codecov by Sentry. |
39081fd
to
3faff84
Compare
3faff84
to
2bdaedb
Compare
2bdaedb
to
1276912
Compare
1276912
to
039de65
Compare
bab6ce1
to
9e43bff
Compare
lvrach
approved these changes
Sep 8, 2023
fracasula
reviewed
Sep 11, 2023
9e43bff
to
c72ab15
Compare
Sidddddarth
approved these changes
Sep 11, 2023
fracasula
approved these changes
Sep 11, 2023
cisse21
approved these changes
Sep 11, 2023
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Router iterator, batchrouter & stash can now perform a single SQL query for retrieving jobs instead of multiple.
The above behaviour is toggleable through a feature flag,
JobsDB.useSingleGetJobsQuery
. If the flag is disabled, rudder-server falls back to its previous behaviour.Querying
Caching
Linear Ticket
PIPE-219
Security