chore: check list permissions for replay #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3873 +/- ##
==========================================
- Coverage 68.90% 68.79% -0.11%
==========================================
Files 351 351
Lines 52752 52757 +5
==========================================
- Hits 36348 36294 -54
- Misses 14087 14142 +55
- Partials 2317 2321 +4
☔ View full report in Codecov by Sentry. |
BonapartePC
force-pushed
the
chore.checkReplayPermissions
branch
from
e4388e3
to
fe8a001
Compare
achettyiitr
approved these changes
Sep 15, 2023
BonapartePC
requested review from
achettyiitr,
a team,
lvrach,
fracasula,
cisse21 and
Sidddddarth
and removed request for
a team
atzoum
approved these changes
Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR,
Add a check for list permission. This permission is required for doing a replay.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-94/verify-replay-will-work-when-custom-object-storage-is-defined
Security