Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup JobsDB.useSingleGetJobsQuery config option #3893

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 20, 2023

Description

JobsDB.useSingleGetJobsQuery is no longer needed after successful rollout of the change.

Linear Ticket

PIPE-303

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the chore.jobsdbCleanup branch 2 times, most recently from 9cf9c91 to 695fa0d Compare September 20, 2023 10:30
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 56.00% and project coverage change: -0.02% ⚠️

Comparison is base (f6c51b7) 69.15% compared to head (e2eefe3) 69.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3893      +/-   ##
==========================================
- Coverage   69.15%   69.13%   -0.02%     
==========================================
  Files         353      353              
  Lines       53026    52903     -123     
==========================================
- Hits        36669    36574      -95     
+ Misses      14052    14006      -46     
- Partials     2305     2323      +18     
Files Changed Coverage Δ
jobsdb/jobsdb.go 73.19% <ø> (+1.99%) ⬆️
router/handle.go 71.02% <ø> (-1.55%) ⬇️
processor/stash/stash.go 52.70% <42.85%> (+5.30%) ⬆️
router/batchrouter/handle.go 63.39% <62.50%> (+2.23%) ⬆️
router/internal/jobiterator/jobiterator.go 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit be0a62e into master Sep 25, 2023
35 checks passed
@cisse21 cisse21 deleted the chore.jobsdbCleanup branch September 25, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants