Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: send filtered events in ut as dropped #3972

Merged

Conversation

chandumlg
Copy link
Member

@chandumlg chandumlg commented Oct 12, 2023

Description

  1. Fixes the issue of sending filtered events in UT to the live events as failed. With this fix, filtered events in ut are sent as dropped.
  2. Stores failed events during event filtering in proc errors.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5a74b34) 70.52% compared to head (e0a15ff) 70.51%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.15.x    #3972      +/-   ##
==================================================
- Coverage           70.52%   70.51%   -0.01%     
==================================================
  Files                 357      357              
  Lines               53651    53660       +9     
==================================================
+ Hits                37835    37836       +1     
- Misses              13558    13565       +7     
- Partials             2258     2259       +1     
Files Coverage Δ
jobsdb/jobsdb.go 73.23% <ø> (-0.29%) ⬇️
processor/processor.go 88.30% <100.00%> (-0.12%) ⬇️
...ger/transformation/transformationStatusUploader.go 45.11% <0.00%> (-0.87%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit b7590d2 into release/1.15.x Oct 13, 2023
40 checks passed
@cisse21 cisse21 deleted the fix.dont-send-filtered-to-transformation-live-events branch October 13, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants