feat: introducing warehouse repo withTx #4042
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
+ Coverage 71.52% 71.55% +0.02%
==========================================
Files 373 373
Lines 54838 54827 -11
==========================================
+ Hits 39224 39231 +7
+ Misses 13275 13263 -12
+ Partials 2339 2333 -6
☔ View full report in Codecov by Sentry. |
achettyiitr
force-pushed
the
feat.repo-withtx
branch
from
a80770f
to
b8b59f0
Compare
|
|
||
| if err := f(tx); err != nil { | ||
| if rollbackErr := tx.Rollback(); rollbackErr != nil { | ||
| return fmt.Errorf("rollback transaction for %w: %w", err, rollbackErr) |
There was a problem hiding this comment.
This is like a Nando's double 🐔 wrap but with errors 😅
There was a problem hiding this comment.
I am a bit skeptical here. Should we ignore rollback error?
There was a problem hiding this comment.
Nah, it's OK. It works perfectly fine and it is possible to unwrap both errors 👍
There was a problem hiding this comment.
I wasn't aware that is possible to wrap two errors that the same time, cool
achettyiitr
force-pushed
the
feat.repo-withtx
branch
from
d167bf2
to
7d12055
Compare
| defer func() { _ = stmt.Close() }() | ||
|
|
||
| for _, loadFile := range loadFiles { | ||
| metadata := fmt.Sprintf(`{"content_length": %d, "destination_revision_id": %q, "use_rudder_storage": %t}`, loadFile.ContentLength, loadFile.DestinationRevisionID, loadFile.UseRudderStorage) |
There was a problem hiding this comment.
[minor] I would prefer a proper json.Marshal(), IMO is cleaner and safer
|
|
||
| if err := f(tx); err != nil { | ||
| if rollbackErr := tx.Rollback(); rollbackErr != nil { | ||
| return fmt.Errorf("rollback transaction for %w: %w", err, rollbackErr) |
There was a problem hiding this comment.
I wasn't aware that is possible to wrap two errors that the same time, cool
Description
WithTxto use wherever transactions are used.WithTxis required during reporting where we update fields and report to reporting in the same transaction.Linear Ticket
Security