Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set gw rate limits at event level #4069

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Nov 2, 2023

Description

Tweaking the existing GW Rate Limiter to throttle based on the incoming events rather than requests

Linear Ticket

Fixes PIPE-475

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum changed the title fix : set gw ratelimits at event level chore: set gw rate limits at event level Nov 2, 2023
gateway/handle.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (b80d273) 71.53% compared to head (8d7068f) 71.85%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4069      +/-   ##
==========================================
+ Coverage   71.53%   71.85%   +0.31%     
==========================================
  Files         373      373              
  Lines       54826    54905      +79     
==========================================
+ Hits        39219    39451     +232     
+ Misses      13272    13136     -136     
+ Partials     2335     2318      -17     
Files Coverage Δ
gateway/throttler/throttler.go 80.28% <100.00%> (ø)
processor/trackingplan.go 95.45% <100.00%> (ø)
processor/transformer/transformer.go 90.79% <100.00%> (ø)
warehouse/api/http.go 78.94% <100.00%> (ø)
warehouse/app.go 89.59% <100.00%> (ø)
warehouse/integrations/testhelper/setup.go 99.68% <100.00%> (ø)
warehouse/internal/model/upload.go 100.00% <ø> (ø)
warehouse/internal/repo/repo.go 70.00% <100.00%> (+14.44%) ⬆️
warehouse/internal/repo/upload.go 91.39% <100.00%> (+0.37%) ⬆️
warehouse/integrations/testhelper/verify.go 89.64% <91.66%> (ø)
... and 9 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 8dd4ab9 into master Nov 2, 2023
35 checks passed
@cisse21 cisse21 deleted the fix.countEventsGWThrottle branch November 2, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants