-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: have processor dropped stats to include only source info and not destination #4087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4087 +/- ##
==========================================
- Coverage 71.95% 71.90% -0.05%
==========================================
Files 372 372
Lines 54831 54850 +19
==========================================
- Hits 39453 39442 -11
- Misses 13061 13095 +34
+ Partials 2317 2313 -4
☔ View full report in Codecov by Sentry. |
7c66625
to
600a2e8
Compare
var jobTargetKey JobTargetKey | ||
var recordId string | ||
remaining := 5 | ||
jp := gjson.ParseBytes(jobParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any benefit of doing ParseBytes instead of unmarshaling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is iterating over the field tokens, so we can gain some iterations as soon as we are done with the fields we are interested in (performance benefit)
600a2e8
to
b6624b8
Compare
Description
Have processor dropped stats to include only source info and not destination.
Linear Ticket
retl Ticket comment
Security