Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: have processor dropped stats to include only source info and not destination #4087

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

Sidddddarth
Copy link
Member

Description

Have processor dropped stats to include only source info and not destination.

Linear Ticket

retl Ticket comment

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title chore(rsources): save proc drops to source failed chore: have processor dropped stats to include only source info and not destination Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2e0b10) 71.95% compared to head (b6624b8) 71.90%.

❗ Current head b6624b8 differs from pull request most recent head dd4eff9. Consider uploading reports for the commit dd4eff9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
- Coverage   71.95%   71.90%   -0.05%     
==========================================
  Files         372      372              
  Lines       54831    54850      +19     
==========================================
- Hits        39453    39442      -11     
- Misses      13061    13095      +34     
+ Partials     2317     2313       -4     
Files Coverage Δ
processor/processor.go 89.07% <100.00%> (+0.01%) ⬆️
services/rsources/stats_collector.go 91.16% <100.00%> (+0.85%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

services/rsources/stats_collector.go Outdated Show resolved Hide resolved
services/rsources/stats_collector.go Outdated Show resolved Hide resolved
services/rsources/stats_collector.go Outdated Show resolved Hide resolved
services/rsources/stats_collector.go Outdated Show resolved Hide resolved
services/rsources/stats_collector.go Outdated Show resolved Hide resolved
@Sidddddarth Sidddddarth force-pushed the chore.storeProcessorDroppedToSourceFailed branch from 7c66625 to 600a2e8 Compare November 7, 2023 12:02
var jobTargetKey JobTargetKey
var recordId string
remaining := 5
jp := gjson.ParseBytes(jobParams)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any benefit of doing ParseBytes instead of unmarshaling?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is iterating over the field tokens, so we can gain some iterations as soon as we are done with the fields we are interested in (performance benefit)

@Sidddddarth Sidddddarth force-pushed the chore.storeProcessorDroppedToSourceFailed branch from 600a2e8 to b6624b8 Compare November 8, 2023 03:51
@Sidddddarth Sidddddarth merged commit 68cf612 into master Nov 8, 2023
33 checks passed
@Sidddddarth Sidddddarth deleted the chore.storeProcessorDroppedToSourceFailed branch November 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants