chore: filtered and error stats separated in processor #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
requested review from
atzoum,
BonapartePC,
fracasula,
achettyiitr and
pChondros
atzoum
reviewed
Nov 14, 2023
Comment on lines
+1091
to
+1103
| func (proc *Handle) getNonSuccessfulMetrics( | ||
| response transformer.Response, | ||
| commonMetaData *transformer.Metadata, | ||
| eventsByMessageID map[string]types.SingularEventWithReceivedAt, | ||
| inPU, pu string, | ||
| ) *NonSuccessfulTransformationMetrics { |
There was a problem hiding this comment.
Personal preference: I don't find that by splitting a single line, that fits perfectly in the screen, into multiple lines makes the codebase more readable
There was a problem hiding this comment.
It's not fitting on my screen, I'm having to turn my head and sometimes worse: scroll!
To each their own though, can revert if it's becoming a nuisance for everyone
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4137 +/- ##
==========================================
- Coverage 72.55% 72.40% -0.16%
==========================================
Files 383 383
Lines 55476 55521 +45
==========================================
- Hits 40252 40201 -51
- Misses 12909 12987 +78
- Partials 2315 2333 +18 ☔ View full report in Codecov by Sentry. |
cisse21
reviewed
Nov 14, 2023
Sidddddarth
changed the title
Sidddddarth
force-pushed
the
chore.procErrorStatTag_isDropped
branch
6 times, most recently
from
7fbe2dc
to
ce39541
Compare
Sidddddarth
force-pushed
the
chore.procErrorStatTag_isDropped
branch
from
ce39541
to
8e73bcb
Compare
atzoum
approved these changes
Nov 21, 2023
cisse21
approved these changes
Nov 21, 2023
This was referenced Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
separates filtered and error stats in processor.
Linear Ticket
slack thread
Security