Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use local db in rsources handler for verifying job completed status #4245

Merged
merged 1 commit into from Dec 19, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Dec 18, 2023

Description

Before deleting stats for a job status, we are verifying first that the job is completed, so that we won't end up recording corrupted stats after a partial delete.
In case shared db is enabled, we shouldn't be using it for performing this verification, since it is being updated asynchronously through logical replication, so it is possible that it doesn't contain the latest stats. We should always be using the local db for such a verification.

Linear Ticket

resolves PIPE-636

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Dec 18, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95ff5ae) 73.82% compared to head (51ec97b) 73.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4245      +/-   ##
==========================================
- Coverage   73.82%   73.81%   -0.01%     
==========================================
  Files         388      388              
  Lines       54832    54834       +2     
==========================================
- Hits        40479    40475       -4     
- Misses      12032    12036       +4     
- Partials     2321     2323       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum changed the title chore: use local db in rsources handler for verifying completed status chore: use local db in rsources handler for verifying job completed status Dec 19, 2023
@atzoum atzoum marked this pull request as ready for review December 19, 2023 06:25
@atzoum atzoum merged commit d53aa80 into master Dec 19, 2023
47 of 51 checks passed
@atzoum atzoum deleted the chore.incompleteStats branch December 19, 2023 06:51
This was referenced Jan 15, 2024
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants