feat: filter destinations for events from rETL in processor

[mihir20]

Description

For events received through rETL endpoints, destination ID for an event will be stored in params field in JobsDB. For all the events having destination ID in params should be delivered to only those destinations irrespective of how many other destinations are connected to the source. All the other destinations will be filtered at processor.

Base PR: #4234

Linear Ticket

pipe-620

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[atzoum]

I fear this won't be reliable under all circumstances, at least if there are mixed events for the same source in the same batch, i.e. some events having a destination_id and some others not having anything or having another destination_id: Both TransformerEvent.Metadata & TransformerEvent.Destination are being overwritten during Handle#validateEvents based on the value found in the first event of the batch! (see proc#getTransformerEvents)

We could fill TransformerEvent.Metadata.DestinationID and then read it from TransformerResponse.Metadata.DestinationID, but having to rely on an external service for making sure that this field is being transferred properly is not the safest approach. Furthermore, proc#getTransformerEvents is a generic method used by other steps as well & we wouldn't want to break other steps :/

We might need to find an alternative strategy

[mihir20]

Ack have thought of another strategy will update the PR

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (866393d) 73.95% compared to head (49550b3) 73.95%.
Report is 23 commits behind head on master.

❗ Current head 49550b3 differs from pull request most recent head 9c3b414. Consider uploading reports for the commit 9c3b414 to get more accurate results

Files	Patch %	Lines
processor/processor.go	66.66%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   73.95%   73.95%   -0.01%     
==========================================
  Files         389      390       +1     
  Lines       55209    55272      +63     
==========================================
+ Hits        40831    40877      +46     
- Misses      12054    12068      +14     
- Partials     2324     2327       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.