chore: enabling gateway to ingest events even when sharedDB is down #4262

mihir20 · 2023-12-27T10:37:48Z

Description

Gateway was not able to start web server, If sharedDB is down for some reason. Following steps in startup are blocking web server to start.

RSources service was not able to start as it was not able to connect with sharedDB and setup db tables and replication.
DrainConfigManager was not able start and run migrations for the drain config db tables present in shared DB.

Solution:
When a new gateway instance is coming up,

while setting up RSources service we will not setup sharedDB tables and replication.
while setting up DrainConfigManager we will not halt gateway setup on failure of migration for drain config tables.

We will raise an alert for the failure logs. AI for the alert will be to restart gateway instance.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-484/gateway-should-accept-data-even-if-it-is-not-able-to-connect-with

Security

The code changed/added as part of this pull request won't create any security issues with how the software is being used.

coderabbitai · 2023-12-27T10:37:54Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

internal/drain-config/drainConfig.go

services/rsources/handler.go

atzoum · 2023-12-27T13:44:15Z

app/apphandlers/gatewayAppHandler.go

@@ -132,23 +132,26 @@ func (a *gatewayApp) StartRudderCore(ctx context.Context, options *app.Options)
 	})
 	drainConfigManager, err := drain_config.NewDrainConfigManager(config, a.log.Child("drain-config"))
 	if err != nil {
-		return fmt.Errorf("drain config manager setup: %v", err)
+		a.log.Errorw("drain config manager setup fail", "error", err)


So in case of an error, gateway will be operating in degraded mode, at least with respect to draining jobs. Do we plan to setup a P0 alert for this?

yes we will setup an alert for this

It would be nice to have the relevant pr mentioned here :)

https://github.com/rudderlabs/rudder-devops/pull/9820

internal/drain-config/drainConfig.go

services/rsources/handler.go

internal/drain-config/drainConfig.go

app/apphandlers/gatewayAppHandler.go

lvrach

Approved with non blocking comment

codecov · 2024-01-08T09:43:38Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b928bfe) 73.88% compared to head (e830c70) 73.90%.

Files	Patch %	Lines
internal/drain-config/http.go	25.00%	2 Missing and 1 partial ⚠️
app/apphandlers/gatewayAppHandler.go	77.77%	2 Missing ⚠️
app/apphandlers/processorAppHandler.go	0.00%	1 Missing ⚠️
internal/drain-config/drainConfig.go	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
+ Coverage   73.88%   73.90%   +0.02%     
==========================================
  Files         388      388              
  Lines       55127    55127              
==========================================
+ Hits        40730    40742      +12     
+ Misses      12069    12059      -10     
+ Partials     2328     2326       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sidddddarth requested a review from atzoum December 27, 2023 12:02

atzoum reviewed Dec 27, 2023

View reviewed changes

internal/drain-config/drainConfig.go Outdated Show resolved Hide resolved

services/rsources/handler.go Outdated Show resolved Hide resolved

mihir20 force-pushed the mihir/pipe-484 branch 3 times, most recently from bb88d01 to 54b8444 Compare December 27, 2023 13:27

mihir20 requested review from atzoum, lvrach, fracasula, cisse21, BonapartePC, achettyiitr and Sidddddarth December 27, 2023 13:27

atzoum reviewed Dec 27, 2023

View reviewed changes

internal/drain-config/drainConfig.go Show resolved Hide resolved

achettyiitr reviewed Dec 27, 2023

View reviewed changes

mihir20 requested review from achettyiitr and atzoum December 28, 2023 09:55

achettyiitr approved these changes Dec 29, 2023

View reviewed changes

lvrach approved these changes Jan 8, 2024

View reviewed changes

cisse21 approved these changes Jan 8, 2024

View reviewed changes

mihir20 added 3 commits January 8, 2024 14:33

chore: enabling gateway to ingest events even when sharedDB is down

22adb03

addressed comments

4315046

fix unit tests

e830c70

mihir20 force-pushed the mihir/pipe-484 branch from 497aee8 to e830c70 Compare January 8, 2024 09:25

mihir20 merged commit bd365b5 into master Jan 8, 2024
42 checks passed

devops-github-rudderstack mentioned this pull request Jan 8, 2024

chore: prerelease 1.19.0-rc.1 #4293

Merged

cisse21 deleted the mihir/pipe-484 branch January 8, 2024 10:08

devops-github-rudderstack mentioned this pull request Jan 10, 2024

chore: prerelease 1.19.0-rc-2 #4298

Merged

This was referenced Jan 15, 2024

chore: prerelease 1.19.0-rc.3 #4314

Merged

chore: release 1.19.0 #4316

Merged

This was referenced Feb 9, 2024

chore: release 1.19.0 #4382

Closed

chore: prerelease 1.20.0-rc.1 #4383

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enabling gateway to ingest events even when sharedDB is down #4262

chore: enabling gateway to ingest events even when sharedDB is down #4262

mihir20 commented Dec 27, 2023 •

edited

Loading

coderabbitai bot commented Dec 27, 2023 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

atzoum Dec 27, 2023

mihir20 Dec 27, 2023

atzoum Dec 27, 2023

mihir20 Dec 28, 2023

lvrach left a comment

codecov bot commented Jan 8, 2024

chore: enabling gateway to ingest events even when sharedDB is down #4262

chore: enabling gateway to ingest events even when sharedDB is down #4262

Conversation

mihir20 commented Dec 27, 2023 • edited Loading

Description

Linear Ticket

Security

coderabbitai bot commented Dec 27, 2023 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

atzoum Dec 27, 2023

Choose a reason for hiding this comment

mihir20 Dec 27, 2023

Choose a reason for hiding this comment

atzoum Dec 27, 2023

Choose a reason for hiding this comment

mihir20 Dec 28, 2023

Choose a reason for hiding this comment

lvrach left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 8, 2024

Codecov Report

mihir20 commented Dec 27, 2023 •

edited

Loading

coderabbitai bot commented Dec 27, 2023 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)