Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logs during processor stash test #4317

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

achettyiitr
Copy link
Member

Description

  • Currently, we are logging as a byte sequence. GA link.
    stash_test.go:159: file list:  [0xc0007a10b0 0xc0007a10e0]  err:  <nil> len:  2
    stash_test.go:159: file list:  [0xc000bb83f0 0xc000bb8420]  err:  <nil> len:  2
    stash_test.go:153: 
        	Error Trace:	/home/runner/work/rudder-server/rudder-server/processor/stash/stash_test.go:153
        	Error:      	Condition never satisfied
        	Test:       	TestStoreErrorsToObjectStorage
        	Messages:   	no backup files found in backup store: %!(EXTRA <nil>)
--- FAIL: TestStoreErrorsToObjectStorage (26.17s)
  • Log as string instead of byte sequence for better debuggability.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@rudderlabs rudderlabs deleted a comment from coderabbitai bot Jan 16, 2024
@rudderlabs rudderlabs deleted a comment from coderabbitai bot Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b82920) 74.06% compared to head (ded16f7) 74.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
+ Coverage   74.06%   74.08%   +0.01%     
==========================================
  Files         390      390              
  Lines       55274    55274              
==========================================
+ Hits        40940    40947       +7     
+ Misses      12006    12000       -6     
+ Partials     2328     2327       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula merged commit a09f39f into master Jan 16, 2024
43 checks passed
@fracasula fracasula deleted the chore.improve-error-logging branch January 16, 2024 10:03
Sidddddarth pushed a commit that referenced this pull request Jan 17, 2024
chore: improve error logs during processor stash test:
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants