-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard Yandex Metrica Offline Events destination #4534
feat: onboard Yandex Metrica Offline Events destination #4534
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
...chrouter/asyncdestinationmanager/yandex-metrica-offline-events/yandexmetricaofflineevents.go
Outdated
Show resolved
Hide resolved
...chrouter/asyncdestinationmanager/yandex-metrica-offline-events/yandexmetricaofflineevents.go
Outdated
Show resolved
Hide resolved
...chrouter/asyncdestinationmanager/yandex-metrica-offline-events/yandexmetricaofflineevents.go
Outdated
Show resolved
Hide resolved
…t.yandex.metrica.offline.event.dest
….offline.event.dest
…udderlabs/rudder-server into feat.yandex.metrica.offline.event.dest
…udderlabs/rudder-server into feat.yandex.metrica.offline.event.dest
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4534 +/- ##
========================================
Coverage 74.57% 74.58%
========================================
Files 406 408 +2
Lines 48092 48381 +289
========================================
+ Hits 35866 36084 +218
- Misses 9897 9945 +48
- Partials 2329 2352 +23 ☔ View full report in Codecov by Sentry. |
…udderlabs/rudder-server into feat.yandex.metrica.offline.event.dest
…udderlabs/rudder-server into feat.yandex.metrica.offline.event.dest
…udderlabs/rudder-server into feat.yandex.metrica.offline.event.dest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(partial review)
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go
Outdated
Show resolved
Hide resolved
csvWriter := csv.NewWriter(csvFile) | ||
|
||
// Define the header row based on key presence in "message" object | ||
firstMsgIdDetails, err := ymMsgsBody[0].Id() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could len(ymMsgsBody)==0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we are handling that validation in the transformer itself.
fmt.Sprintf("%v", idDetails.id), | ||
fmt.Sprintf("%v", ymMsg.Target), | ||
fmt.Sprintf("%v", ymMsg.DateTime), | ||
fmt.Sprintf("%v", ymMsg.Price), | ||
fmt.Sprintf("%v", ymMsg.Currency), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the intended out here? Is the behaviour of %v, match the expectations under all conditions? Should we use a more standarize way to encode them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building a stringArray
and pass it to csvWriter
to form a row of data in the csv being passed to Yandex Metrica.
Updated to use strconv
Description
Onboarding a new batch router bulk upload Oauth destination Yandex Metrica Offline Events
Linear Ticket
https://linear.app/rudderstack/issue/INT-1747/backend-changes
Resolves INT-1747
Security