fix: health check for ssh server

[achettyiitr]

Description

• There seem to be some changes made in the latest docker image which was published 4 days back. I tried with an older image 9.3_p2-r1-ls145 and it's working there.

Linear Ticket

• Resolves PIPE-966, PIPE-962

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mihir20]

LGTM

[fracasula]

Nice. It'd be useful to understand why it's failing in the latest. Not too important though so if it becomes a 🐰 🕳️ then I think we can stick to this version for now.

[fracasula]

@achettyiitr somehow this is still failing:

        container test_jjswjuxjacoccozqbkkz-ssh-server-1 is unhealthy
        , err: exit status 1
    --- FAIL: TestUploads/tunnelling (68.63s)

[achettyiitr]

@achettyiitr somehow this is still failing:

        container test_jjswjuxjacoccozqbkkz-ssh-server-1 is unhealthy
        , err: exit status 1
    --- FAIL: TestUploads/tunnelling (68.63s)

Yeah, checking. I just checked for postgres and it s succeeding

[fracasula]

Maybe it's something related to their rebase to alpine 3.19.

[fracasula]

They did a security upgrade: https://www.alpinelinux.org/posts/Alpine-3.19.1-released.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.47%. Comparing base (5f2e0e6) to head (e830e86).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
+ Coverage   74.31%   74.47%   +0.16%     
==========================================
  Files         413      413              
  Lines       48368    48368              
==========================================
+ Hits        35943    36023      +80     
+ Misses      10080    10018      -62     
+ Partials     2345     2327      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[achettyiitr]

With the current changes, I tried to run 3 times and it succeeded. https://github.com/rudderlabs/rudder-server/actions/runs/8560392325?pr=4551
Merging it then.