chore: add support for live events in internal batch endpoint #4627

mihir20 · 2024-04-29T11:23:53Z

Description

Added support for live events in internal batch endpoint
Small refactoring, to make stats function more specific to the usecase and use actual source config and not auth context

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-842/%5Bingestionsvc%5D-source-live-events

Security

The code changed/added as part of this pull request won't create any security issues with how the software is being used.

coderabbitai · 2024-04-29T11:23:58Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-04-29T11:35:18Z

Codecov Report

Attention: Patch coverage is 86.27451% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.55%. Comparing base (904d8fb) to head (49a8055).
Report is 2 commits behind head on master.

Files	Patch %	Lines
services/debugger/source/mocks/mock.go	70.00%	6 Missing ⚠️
gateway/handle.go	96.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4627      +/-   ##
==========================================
- Coverage   74.66%   74.55%   -0.12%     
==========================================
  Files         408      409       +1     
  Lines       48381    48423      +42     
==========================================
- Hits        36124    36100      -24     
- Misses       9905     9964      +59     
- Partials     2352     2359       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gateway/handle.go

lvrach · 2024-04-29T11:45:15Z

gateway/handle.go

+
+			// Sending events to config backend
+			for _, job := range jobs {
+				writeKey, ok := jobsUUIDToWriteKeyMap[job.UUID]


What if we call gw.writeKeyForSourceID here instead of passing the jobsUUIDToWriteKeyMap ?

do you mean to say, we get the source ID from params and call writeKeyForSourceID with sourceID?

gateway/handle_observability.go

Sidddddarth

Didn't understand the motivation behind changing some stat functions.
Otherwise LGTM

gateway/gateway_test.go

gateway/handle.go

gateway/handle_observability.go

lvrach · 2024-04-30T11:45:49Z

services/debugger/source/eventUploader.go

@@ -1,5 +1,6 @@
 package sourcedebugger

+//go:generate mockgen -destination=./mocks/mock.go -package=mocks github.com/rudderlabs/rudder-server/services/debugger/source SourceDebugger


[minor] [non-blocking] Do we need to generate a mock? The interface signature seems simple enough to mock by hand.

Its simpler to just generate a mock, mock by hand feels too much manual work(in writing a mock as well as to maintain it) :D

mihir20 marked this pull request as draft April 29, 2024 11:26

mihir20 force-pushed the mihir/pipe-842 branch 2 times, most recently from 3324ff7 to 20b0301 Compare April 29, 2024 11:36

mihir20 changed the title ~~chore: add support for live events in internal endpoint~~ chore: add support for live events in internal batch endpoint Apr 29, 2024

lvrach reviewed Apr 29, 2024

View reviewed changes

gateway/handle.go Outdated Show resolved Hide resolved

lvrach reviewed Apr 29, 2024

View reviewed changes

chore: add support for live events in internal batch endpoint

bce0b20

mihir20 force-pushed the mihir/pipe-842 branch from 20b0301 to bce0b20 Compare April 29, 2024 13:57

mihir20 requested a review from lvrach April 29, 2024 13:57

mihir20 added 2 commits April 29, 2024 19:58

added unit tests for live events handling in internal batch endpoint

099b1ec

lint fix

a8bf86f

mihir20 force-pushed the mihir/pipe-842 branch from 498971d to a8bf86f Compare April 29, 2024 14:41

mihir20 marked this pull request as ready for review April 29, 2024 14:54

Sidddddarth reviewed Apr 29, 2024

View reviewed changes

gateway/handle_observability.go Outdated Show resolved Hide resolved

addressed comments

16ac3ec

mihir20 requested a review from Sidddddarth April 29, 2024 15:47

Sidddddarth approved these changes Apr 30, 2024

View reviewed changes

achettyiitr reviewed Apr 30, 2024

View reviewed changes

gateway/gateway_test.go Outdated Show resolved Hide resolved

gateway/handle.go Outdated Show resolved Hide resolved

gateway/handle.go Show resolved Hide resolved

gateway/handle_observability.go Outdated Show resolved Hide resolved

lvrach reviewed Apr 30, 2024

View reviewed changes

addressed comments

fac5b13

achettyiitr approved these changes Apr 30, 2024

View reviewed changes

fixed UTs

49a8055

mihir20 merged commit 26ecd98 into master Apr 30, 2024
52 checks passed

mihir20 deleted the mihir/pipe-842 branch April 30, 2024 12:47

This was referenced May 6, 2024

chore: release 1.25.0 #4641

Closed

chore: release 1.25.0 #4642

Closed

chore: prerelease 1.25.0-rc.1 #4643

Closed

This was referenced May 6, 2024

chore: prerelease 1.25.0-rc.1 #4644

Merged

chore: release 1.25.0 #4646

Merged

chore: prerelease 1.25.0-rc.1 #4647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add support for live events in internal batch endpoint #4627

chore: add support for live events in internal batch endpoint #4627

mihir20 commented Apr 29, 2024 •

edited

coderabbitai bot commented Apr 29, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Apr 29, 2024 •

edited

lvrach Apr 29, 2024

mihir20 Apr 29, 2024

Sidddddarth left a comment

lvrach Apr 30, 2024 •

edited

mihir20 Apr 30, 2024 •

edited

		@@ -1,5 +1,6 @@
		package sourcedebugger

		//go:generate mockgen -destination=./mocks/mock.go -package=mocks github.com/rudderlabs/rudder-server/services/debugger/source SourceDebugger

chore: add support for live events in internal batch endpoint #4627

chore: add support for live events in internal batch endpoint #4627

Conversation

mihir20 commented Apr 29, 2024 • edited

Description

Linear Ticket

Security

coderabbitai bot commented Apr 29, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Apr 29, 2024 • edited

Codecov Report

lvrach Apr 29, 2024

Choose a reason for hiding this comment

mihir20 Apr 29, 2024

Choose a reason for hiding this comment

Sidddddarth left a comment

Choose a reason for hiding this comment

lvrach Apr 30, 2024 • edited

Choose a reason for hiding this comment

mihir20 Apr 30, 2024 • edited

Choose a reason for hiding this comment

mihir20 commented Apr 29, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 29, 2024 •

edited

lvrach Apr 30, 2024 •

edited

mihir20 Apr 30, 2024 •

edited