Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clevertap): parameters ordering issue #2727

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

mihir-4116
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 requested a review from a team as a code owner October 16, 2023 13:43
@mihir-4116 mihir-4116 requested review from utsabc and sandeepdsvs and removed request for a team October 16, 2023 13:43
@mihir-4116 mihir-4116 self-assigned this Oct 16, 2023
@mihir-4116 mihir-4116 requested a review from a team as a code owner October 16, 2023 13:48
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1de7d94) 87.24% compared to head (d634017) 87.24%.

Additional details and impacted files
@@                Coverage Diff                @@
##           hotfix/clevertap    #2727   +/-   ##
=================================================
  Coverage             87.24%   87.24%           
=================================================
  Files                   641      641           
  Lines                 28519    28519           
  Branches               6780     6780           
=================================================
  Hits                  24880    24880           
  Misses                 3310     3310           
  Partials                329      329           
Files Coverage Δ
src/v0/destinations/clevertap/transform.js 98.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.8% 92.8% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 changed the title fix(clevertap): invalid parameters ordering issue fix(clevertap): parameters ordering issue Oct 16, 2023
@mihir-4116 mihir-4116 merged commit bd6e096 into hotfix/clevertap Oct 17, 2023
17 checks passed
@mihir-4116 mihir-4116 deleted the fix.clevertap branch October 17, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants