Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplication key issue #2757

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: deduplication key issue #2757

merged 1 commit into from
Oct 20, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Resolved RUD-852

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Oct 20, 2023
@anantjain45823 anantjain45823 requested review from a team as code owners October 20, 2023 03:17
@anantjain45823 anantjain45823 changed the base branch from develop to hotfix/v1.46.3 October 20, 2023 03:17
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d65048) 87.50% compared to head (02464ba) 87.29%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           hotfix/v1.46.3    #2757      +/-   ##
==================================================
- Coverage           87.50%   87.29%   -0.22%     
==================================================
  Files                 698      698              
  Lines               29070    28640     -430     
  Branches             6960     6789     -171     
==================================================
- Hits                25438    25000     -438     
- Misses               3300     3314      +14     
+ Partials              332      326       -6     
Files Coverage Δ
...c/v0/destinations/snapchat_conversion/transform.js 95.31% <100.00%> (+3.10%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anantjain45823 anantjain45823 merged commit bc76305 into hotfix/v1.46.3 Oct 20, 2023
14 of 15 checks passed
@anantjain45823 anantjain45823 deleted the fix.snapCon2 branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants