feat: onboard new destination ninetailed #3106
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe recent update introduces comprehensive configuration settings and utility functions for managing event data in the Ninetailed destination within a CDK. It enhances event batching, payload construction, and endpoint communication. Integration tests cover various scenarios including validation, tracking, page views, and user identification, ensuring robustness and reliability of the integration. This update streamlines the process of sending events to Ninetailed's platform, improving efficiency and effectiveness of data handling. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3106/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3106 +/- ##
===========================================
+ Coverage 84.59% 84.89% +0.30%
===========================================
Files 493 496 +3
Lines 27308 27333 +25
Branches 6576 6560 -16
===========================================
+ Hits 23101 23205 +104
+ Misses 3754 3704 -50
+ Partials 453 424 -29 ☔ View full report in Codecov by Sentry. |
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (8)
src/cdk/v2/destinations/ninetailed/data/contextMapping.jsonis excluded by:!**/*.jsonsrc/cdk/v2/destinations/ninetailed/data/generalPayloadMapping.jsonis excluded by:!**/*.jsonsrc/cdk/v2/destinations/ninetailed/data/identifyMapping.jsonis excluded by:!**/*.jsonsrc/cdk/v2/destinations/ninetailed/data/pageMapping.jsonis excluded by:!**/*.jsonsrc/cdk/v2/destinations/ninetailed/data/trackMapping.jsonis excluded by:!**/*.jsonsrc/cdk/v2/destinations/ninetailed/procWorkflow.yamlis excluded by:!**/*.yamlsrc/cdk/v2/destinations/ninetailed/rtWorkflow.yamlis excluded by:!**/*.yamlsrc/features.jsonis excluded by:!**/*.json
Files selected for processing (11)
- src/cdk/v2/destinations/ninetailed/config.js (1 hunks)
- src/cdk/v2/destinations/ninetailed/utils.js (1 hunks)
- test/integrations/destinations/ninetailed/processor/commonConfig.ts (1 hunks)
- test/integrations/destinations/ninetailed/processor/data.ts (1 hunks)
- test/integrations/destinations/ninetailed/processor/identify.ts (1 hunks)
- test/integrations/destinations/ninetailed/processor/page.ts (1 hunks)
- test/integrations/destinations/ninetailed/processor/track.ts (1 hunks)
- test/integrations/destinations/ninetailed/processor/validation.ts (1 hunks)
- test/integrations/destinations/ninetailed/router/basicProperties.ts (1 hunks)
- test/integrations/destinations/ninetailed/router/commonConfig.ts (1 hunks)
- test/integrations/destinations/ninetailed/router/data.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- test/integrations/destinations/ninetailed/processor/commonConfig.ts
Additional comments: 9
test/integrations/destinations/ninetailed/processor/data.ts (1)
- 1-5: The changes in
data.tsfor importing modules and aggregating test data into thedataarray are correctly implemented.src/cdk/v2/destinations/ninetailed/config.js (1)
- 1-29: The configuration settings in
config.js, including theMAX_BATCH_SIZEandbatchEndpoint, are correctly implemented and align with the PR objectives.test/integrations/destinations/ninetailed/router/commonConfig.ts (1)
- 1-38: The common configurations in
commonConfig.ts, including input/output structures and destination configuration, are correctly implemented and provide a solid foundation for testing.test/integrations/destinations/ninetailed/router/basicProperties.ts (1)
- 1-33: The event properties and traits defined in
basicProperties.tsare correctly implemented and relevant to the Ninetailed destination.src/cdk/v2/destinations/ninetailed/utils.js (1)
- 1-38: The utility functions in
utils.js, including payload construction and endpoint determination, are correctly implemented and follow best practices.test/integrations/destinations/ninetailed/processor/page.ts (1)
- 1-108: The test scenarios for page events in
page.tsare well-defined and provide comprehensive coverage, aligning with the Ninetailed destination's requirements.test/integrations/destinations/ninetailed/processor/identify.ts (1)
- 1-164: The test scenarios for identify calls in
identify.tsare comprehensive, covering both success and failure cases, and align with the Ninetailed destination's requirements.test/integrations/destinations/ninetailed/processor/validation.ts (1)
- 1-180: The test scenarios for validation failures in
validation.tsare comprehensive and well-defined, covering essential validation requirements and aligning with best practices for testing.test/integrations/destinations/ninetailed/processor/track.ts (1)
- 1-203: The test scenarios for track calls in
track.tsare comprehensive, covering both success and failure cases, and align with the Ninetailed destination's requirements.
test/integrations/destinations/ninetailed/processor/validation.ts
Outdated
Show resolved
Hide resolved
anantjain45823
force-pushed
the
feat.newDestNinetailed
branch
2 times, most recently
from
e741e31
to
aa735f4
Compare
anantjain45823
force-pushed
the
feat.newDestNinetailed
branch
from
aa735f4
to
89bac72
Compare
|
What are the changes introduced in this PR?
Onboard new destination ninetailed.
Write a brief explainer on your code changes.
This destination supports identify, track, and page calls.
Also it supports batching with max batch size as 200
What is the related Linear task?
Resolves INT-295
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit