Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Koala destination #3122

Merged

Conversation

gustavowt
Copy link
Contributor

@gustavowt gustavowt commented Feb 23, 2024

What are the changes introduced in this PR?

Add new destination for Koala

Config -> rudderlabs/config-generator#53
Documentation -> rudderlabs/rudderstack-docs#1186

What is the related Linear task?

N/A

Please explain the objectives of your changes below

Add koala destination support for identify and track events

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link
Contributor

coderabbitai bot commented Feb 23, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@gustavowt gustavowt marked this pull request as draft February 23, 2024 17:45
@gustavowt gustavowt marked this pull request as ready for review February 23, 2024 20:37
@gitcommitshow
Copy link
Collaborator

Thank you for the contribution @gustavowt , the team will review the PR soon. Meanwhile, please sign this CLA

src/cdk/v2/destinations/koala/procWorkflow.yaml Outdated Show resolved Hide resolved
src/cdk/v2/destinations/koala/procWorkflow.yaml Outdated Show resolved Hide resolved
src/cdk/v2/destinations/koala/procWorkflow.yaml Outdated Show resolved Hide resolved
gustavowt and others added 2 commits March 1, 2024 11:11
Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com>
Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com>
Gauravudia
Gauravudia previously approved these changes Mar 6, 2024
Copy link
Contributor

@yashasvibajpai yashasvibajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor test description improvements

test/integrations/destinations/koala/processor/data.ts Outdated Show resolved Hide resolved
test/integrations/destinations/koala/processor/data.ts Outdated Show resolved Hide resolved
test/integrations/destinations/koala/processor/data.ts Outdated Show resolved Hide resolved
@Gauravudia
Copy link
Contributor

@gustavowt Have you performed e2e locally for this destination, Including verifying results from Koala platform for both identify and track call?
cc- @shrouti1507 @yashasvibajpai

gustavowt and others added 4 commits March 7, 2024 10:38
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com>
Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com>
@gustavowt
Copy link
Contributor Author

gustavowt commented Mar 7, 2024

@gustavowt Have you performed e2e locally for this destination, Including verifying results from Koala platform for both identify and track call? cc- @shrouti1507 @yashasvibajpai

tested both identify and track and these are all working as expected.

Gauravudia
Gauravudia previously approved these changes Mar 7, 2024
Copy link
Contributor

@Gauravudia Gauravudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lets keep email in properties
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (c1b3736) to head (6b4f6f2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3122      +/-   ##
===========================================
+ Coverage    84.86%   87.70%   +2.84%     
===========================================
  Files          497      546      +49     
  Lines        27412    29514    +2102     
  Branches      6597     7036     +439     
===========================================
+ Hits         23262    25885    +2623     
+ Misses        3723     3291     -432     
+ Partials       427      338      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia changed the title Add Koala destination feat: add Koala destination Mar 11, 2024
@Gauravudia Gauravudia merged commit 1ca039d into rudderlabs:develop Mar 12, 2024
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants