This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Add changeable buttons property and (optionally) animate button changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zydeco thanks for the PR. I'll take a look at it when I can. |
|
@zydeco this looks great. All I'll say is that in the demo, you might want to make it so the buttons appear in order of frequency or placement in the string (though that's completely optional). I'll merge this when you add yourself to the list of contributors in the README! Thanks! |
ruddfawcett
added a commit
that referenced
this pull request
Jun 25, 2014
Add changeable buttons property and (optionally) animate button changes
|
@zydeco Sorry, didn't realize you'd updated your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a buttons property to RFKeyboardToolbar that can be used to change the buttons, and a setButtons:animated: variant that can animate the button changes.
The demo is updated accordingly, to add a button for each distinct word in the field.