-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to be used with CocoaPods #1
Comments
Hey, thanks for the note! Can you link me to an example of a framework header, and I can create one? Or, alternatively you could open up a pull request? |
Sure, it should just be as simple as something like this: https://github.com/mapbox/MapboxGeocoder.swift/blob/master/MapboxGeocoder/MapboxGeocoder.h In this project's case, maybe: #import <UIKit/UIKit.h>
FOUNDATION_EXPORT double NotepadVersionNumber;
FOUNDATION_EXPORT const unsigned char NotepadVersionString[]; All of the Swift files should be included automatically since they are part of the module. I'm not 100% positive this will solve the problem, but I think it should. I will try to experiment more. |
Great, thanks! Let me know what you find, and happy to merge anything in — it doesn't hurt to have a framework header regardless! |
This was a red herring, since CocoaPods provides an umbrella header file and creates all pods as frameworks. The real problem is that per http://stackoverflow.com/a/37089794/977220 the I'll submit a PR for this. It gets complicated when you try to use a One idea I have here is to introduce a safe setter for
|
Another issue here is that |
Awesome, thanks. Yeah — I definitely am going to implement something with Regarding exposing |
Also, debating between |
|
I agree - just checking because I hate camel case |
Just FYI I will still get to this, but my needs for a project changed and I'm not actively blocked by this anymore so it'll be a little later on. That said this is the best-looking GUI-based Markdown renderer I've seen and I'd like to help tune it up for possible future use! |
@incanus do you have the header for CocoaPods in git already? Because if not I have some time on my hands now and can clean some stuff up. Just let me know! |
The header isn’t necessary—CocoaPods makes one for you when it packages your project as a dynamic framework. |
Ah - so just adding |
Fixed by 6a9e702. |
When used via CocoaPods, the
Notepad.framework
is built and included, but the individual classes aren't able to be used. For example,import Notepad
works just fine, but you can't use theNotepad
class in code. Perhaps this is because there is no framework header?This is in a Swift 3.0 project. I maintain frameworks of my own (e.g. Mapbox-iOS-SDK) so I'm fairly familiar with the process here, though I could be making a dumb mistake.
The
pod try Notepad
example just has theNotepad.swift
etc. files included directly in its own module, which is why it works.The text was updated successfully, but these errors were encountered: