Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toFraction and make use of it #14

Open
Rudxain opened this issue Apr 11, 2022 · 1 comment
Open

Fix toFraction and make use of it #14

Rudxain opened this issue Apr 11, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Rudxain
Copy link
Owner

Rudxain commented Apr 11, 2022

The function should return the smallest fraction that when converted to Number yields exactly the same value as the original input, but some inputs cause it to loop too many times and return a bogus fraction. After fixing the bug, I plan on using it in Math.gcd to preserve precision of computations, and Math.factorize to get negative exponents

@Rudxain Rudxain added bug Something isn't working enhancement New feature or request labels Apr 11, 2022
@Rudxain
Copy link
Owner Author

Rudxain commented Oct 4, 2022

It already works now, but some numbers get converted to bogus fractions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant