Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deblocking filter is missing #11

Closed
torokati44 opened this issue Sep 13, 2021 · 2 comments
Closed

Deblocking filter is missing #11

torokati44 opened this issue Sep 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@torokati44
Copy link
Member

torokati44 commented Sep 13, 2021

This is not an essential feature, even the SWF spec itself states that the deblocking hint might be ignored by Flash Player too.

It could still slightly improve the appearance of https://z0r.de/4145 for example - look at the top corner of the white case of the alarm clock, and the rose next to it. Or the sky in https://z0r.de/3711.
I think, at least, that this movie has that hint set.

@torokati44 torokati44 added the enhancement New feature or request label Sep 13, 2021
@torokati44
Copy link
Member Author

Are we sure though, that the deblocking filter is never applied "in-loop" in Flash?
That is, the motion compensation uses the frame before deblocking filter, vs. after?
I think that is the case, because otherwise we would see severe artifacting in any video encoded by FFmpeg for example - which by default assumes deblocking will happen (and in fact due to this, creates more artifacting for us, with no deblocker).

The "in-loop" filter was added in Annex J, see: https://en.wikipedia.org/wiki/Deblocking_filter#H.263_Annex_J_deblocking_filter
Did Sorenson also take this over into FLV1?

@torokati44
Copy link
Member Author

Fixed by #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant