Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penguin Dive #1522

Closed
sombraguerrero opened this issue Nov 7, 2020 · 3 comments
Closed

Penguin Dive #1522

sombraguerrero opened this issue Nov 7, 2020 · 3 comments

Comments

@sombraguerrero
Copy link
Contributor

sombraguerrero commented Nov 7, 2020

I thought this one may be worth posting separately, just as a good example for when development is further along in this space.
The primary issue seems to be event handlers "not being callable." It seems to be primarily onkeydown for the vanilla ones, and then this game also has what appear to be custom event handlers as well, such as onHitBoard, onHitBottom, so I guess I'd be curious if the roadmap also includes support for custom event handling. I also see setMask in there, which I see is being worked on. There are also issues with the judges' scores overflowing and not calculating appropriately. Appears to be some sort of float-int conversion problem. I can log a separate ticket for that if it happens to be deemed outside the AS3 umbrella, but it probably isn't.
penguindive.zip

@sombraguerrero
Copy link
Contributor Author

Just thought I'd attach a few screenshots to display some stuff going on with scores calculation as well. Clearly there's stuff needed in regards to text overlays and such too.
penguin_dive
penguin_dive2
penguin_dive3
penguin_dive4

@sombraguerrero
Copy link
Contributor Author

I thought this was an AS3 title, but apparently it isn't. I don't know exactly what got implemented in the last few builds to affect this change, but the double press of the spacebar is now working properly as of the 1/3/21 nightly. There must have been something in the AVM1 API.

Anyway, the only thing that's a little derpy is the scoring, but I imagine that's probably inherent in how Rust handles floating points.

@sombraguerrero sombraguerrero changed the title Penguin Dive (Probably AS3 related) Penguin Dive Jan 3, 2021
@sombraguerrero
Copy link
Contributor Author

Several milestones of progress have improved this game in my test bed. It turns out that #5900 was the last major piece of the puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant