Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM1 domain locks always fail #325

Closed
Serentty opened this issue Jan 16, 2020 · 6 comments
Closed

AVM1 domain locks always fail #325

Serentty opened this issue Jan 16, 2020 · 6 comments

Comments

@Serentty
Copy link

Territory War seems to be using a domain-locking system where it checks to see if it's hosted on Newgrounds. It seems that Ruffle isn't allowing it to verify its domain properly, causing it to lock up.

@Herschel Herschel changed the title Territory War domain lock doesn't work Domain locks always fail Jan 16, 2020
@Herschel Herschel changed the title Domain locks always fail AVM1 domain locks always fail Jan 16, 2020
@Herschel
Copy link
Member

This requires _url to be implemented (cc #263). We should provide a user configurable way to spoof the URL, as well.

@kmeisthax
Copy link
Member

The quickest fix would be to just accept the URL as a parameter when constructing the instance, and then have _url pull that.

In moviefetch (PR #120) I'll have to do something more elaborate than that, and have it pull the URL from the SwfMovie it gets it's data from. Starting to think it might make sense to also have the player kick off the SWF fetch itself in that case...

@Herschel
Copy link
Member

Yes, I'd prefer to have as much as possible on the Rust side.

@yourdadcares
Copy link

@Justin-CB
Copy link
Contributor

It looks like of the 3 flash games, only Castle Repercussion isn't working(which is strange, as it's one that always loads ruffle, even without ?emulate=flash).

@n0samu
Copy link
Member

n0samu commented Sep 10, 2022

The reason Castle Repercussion isn't working is because it checks specifically for http:// URLs, but Newgrounds is now using HTTPS:

if(checkurl == "http://deletionquality.net/" || checkurl2 == "http://www.deletionquality.net/" || checkurl3 == "http://uploads.ungrounded.net/" || checkurl4 == "http://www.uploads.ungrounded.net/")
{
   gg.gotoAndStop(1);
}

I'll close this issue since Ruffle seems to be working as intended for all of the mentioned cases.

@n0samu n0samu closed this as completed Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants