Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove report bug button on panic screens due to invalid .wasm instantiation #3679

Closed
Poopooracoocoo opened this issue Mar 16, 2021 · 3 comments · Fixed by #4507
Closed

Remove report bug button on panic screens due to invalid .wasm instantiation #3679

Poopooracoocoo opened this issue Mar 16, 2021 · 3 comments · Fixed by #4507
Labels
good first issue Good for newcomers meta Misc. organizational tasks web Issues relating to the HTML5 frontend

Comments

@Poopooracoocoo
Copy link
Collaborator

Poopooracoocoo commented Mar 16, 2021

http://www.juegosjuegos.com/embed/papas-pancakeria (Ruffle nightly 2021-02-02, Chrome 89, Windows 10)
image
heaps of people seem to think that the report bug button will report the bug to the site.

consider renaming the button to "Report bug to Ruffle" or removing it.

it'd also be worth changing up the wording to explain that this is not ruffle's fault.

@relrelb relrelb added the meta Misc. organizational tasks label Mar 17, 2021
@Bale001
Copy link
Member

Bale001 commented Mar 21, 2021

Maybe linking to some type of help page would be better. There could be a page on the ruffle website that shows all the common issues, with solutions to fix them

@Poopooracoocoo
Copy link
Collaborator Author

Poopooracoocoo commented Mar 21, 2021

or a wiki page.

the panic screen where the .wasm file couldn't be found has a link to the wiki

EDIT: see #4047 for a fix for CSP issues

@Poopooracoocoo Poopooracoocoo added the web Issues relating to the HTML5 frontend label Mar 22, 2021
@Herschel Herschel added the good first issue Good for newcomers label May 4, 2021
@Herschel
Copy link
Member

Herschel commented May 4, 2021

This is a good first issue for a new contributor:
Catch CompileErrors from WebAssembly.instantiate/instantiateStreaming, and show an error message without the crash report button.

The error message could link to a wiki page describing common issues, such as if the wasm file is uploaded in ASCII mode instead of BINARY from an FTP client.

@Poopooracoocoo Poopooracoocoo changed the title Remove report bug button on panic screens due to interfering JS code on page Remove report bug button on panic screens due to invalid .wasm instantiation May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers meta Misc. organizational tasks web Issues relating to the HTML5 frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants