Re-entering fullscreen after exiting fullscreen with the escape button does nothing

[EmK530]

Describe the bug

Pretty self-explanatory in the title, right click the game. Click "Enter fullscreen". Then press escape to exit fullscreen.

Re-entering fullscreen will do nothing

Expected behavior

The Enter fullscreen button will stop functioning

Affected platform

Self-hosted version

Operating system

Windows 10

Browser

Opera GX 81

Additional information

No response

[ousia]

I can confirm the issue with https://www.free-culture.tk/ and Firefox.

The context menu doesn’t work, although pressing F in that animation shows full screen again.

This has to be some issue with the context menu implementation.

[Toad06]

Thanks for the report.

This appears to be a regression introduced in nightly-2021-11-12. This should be one of the following commits: nightly-2021-11-11...nightly-2021-11-12

[ousia]

Many thanks for your analysis, @Toad06.

AS full screen was implemented in commit 7ed3885.

@hatal175, could you please check whether that commit is causing this issue?

Many thanks for your help.

[hatal175]

I won't have time to look at this for the near future.
My apologies.

[midgleyc]

More observations on https://www.free-culture.tk/

• using the context menu to alternately "Enter" and "Exit" works
• using the context menu in combination with the "F" key works
• on entering fullscreen, using escape to exit:
  • the first use of F does nothing
  • after this, you can use the context menu or F to full screen again
  • the menu does correctly say "Enter fullscreen", but clicking does nothing. Very odd.

[midgleyc]

The first F also gives a crash:

ruffle.js?id=18798635351:1 Uncaught (in promise) TypeError: Failed to execute 'exitFullscreen' on 'Document': Document not active
    at HTMLElement.exitFullscreen (ruffle.js?id=18798635351:1)
    at HTMLElement.setFullscreen (ruffle.js?id=18798635351:1)
    at ruffle.js?id=18798635351:1
    at O (ruffle.js?id=18798635351:1)
    at u.wbg.__wbg_setFullscreen_9819a8b20564e39b (ruffle.js?id=18798635351:1)
    at <ruffle_web::ui::WebUiBackend as ruffle_core::backend::ui::UiBackend>::set_fullscreen::hb8932a4e3dbe8e7a (chrome-extension://cbggmdieihaghckgejnccepbblogmloe/dist/60a5dad30d6929f3cbe6.wasm:wasm-function[3188]:0x495a3e)
    at ruffle_core::display_object::stage::Stage::set_display_state::h8c6f563a4b0deb1f (chrome-extension://cbggmdieihaghckgejnccepbblogmloe/dist/60a5dad30d6929f3cbe6.wasm:wasm-function[3111]:0x49087a)
    at ruffle_core::avm1::globals::stage::set_display_state::h3c0391613538fd2d (chrome-extension://cbggmdieihaghckgejnccepbblogmloe/dist/60a5dad30d6929f3cbe6.wasm:wasm-function[2517]:0x43bee7)
    at ruffle_core::avm1::function::Executable::exec::h296dedb8318b3717 (chrome-extension://cbggmdieihaghckgejnccepbblogmloe/dist/60a5dad30d6929f3cbe6.wasm:wasm-function[417]:0x152941)
    at <ruffle_core::avm1::object::script_object::ScriptObject as ruffle_core::avm1::object::TObject>::set_local::h1654ff36107c74ea (chrome-extension://cbggmdieihaghckgejnccepbblogmloe/dist/60a5dad30d6929f3cbe6.wasm:wasm-function[1310]:0x346ee6)

"Enter Fullscreen" does not give a crash (or do anything).