Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies missing in setup.py #98

Open
Byron opened this issue Mar 1, 2015 · 2 comments
Open

dependencies missing in setup.py #98

Byron opened this issue Mar 1, 2015 · 2 comments

Comments

@Byron
Copy link

Byron commented Mar 1, 2015

When installing using pip via pip install dataconverters, you will also have to install at least the following dependencies manually ...

  • unicodecsv
  • messytables

... to get it to work.

These should be added to setup.py to automate that process.
Using tox it would be possible to prevent this kind of error in the future, as tox -e py27 would run your unit-tests in a freshly installed virtualenv. If dependencies would be missing, tox would fail to run the tests.

Meta

  • Tested on OSX 10.10.2
  • python 2.7
@rufuspollock
Copy link
Contributor

Those requirements are in the requirements.txt (we tend to use requirements.txt not setup.py for requirements).

@Byron
Copy link
Author

Byron commented Mar 4, 2015

But shouldn't pip install yield the correct result out of the box ? In the installation instructions it clearly says that pip install dataconverters is all it takes. However, the expectation it sets up will not be met.
Therefore I recommend either adjusting the documentation, or make pip pick up the additional dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants