Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup dark mode #47

Closed
rugk opened this issue Jun 5, 2019 · 2 comments · Fixed by #69
Closed

Popup dark mode #47

rugk opened this issue Jun 5, 2019 · 2 comments · Fixed by #69
Labels
enhancement New feature or request
Milestone
1.2

Comments

@rugk
Copy link
Owner

rugk commented Jun 5, 2019 •
edited

Background

Similar to #23 and basically equal to rugk/offline-qr-code#186.

Requested in #23 (comment)

Proposed solution

prefers-color-scheme is theoretically possible too…

Alternatives

manual switch -> no

Additional context

Problem is: Emoji-mart does not support this yet. So we would either have to style it on our own, or it would likely look quite bad.
@rugk rugk added the enhancement New feature or request label Jun 5, 2019
@rugk rugk mentioned this issue Jun 5, 2019
Closed
@rugk
Copy link
Owner Author

rugk commented Jun 5, 2019 •
edited

Blocked by missive/emoji-mart#293 (feel free to upvote)

@rugk rugk added the blocked Cannot be resolved, because we need to wait for something else to be resolved first. label Jun 5, 2019
@rugk
Copy link
Owner Author

rugk commented Dec 22, 2019

missive/emoji-mart#391 has been merged, now unblocked 🎉 😃

@rugk rugk removed the blocked Cannot be resolved, because we need to wait for something else to be resolved first. label Dec 22, 2019
@rugk rugk modified the milestones: next, 1.2 Dec 22, 2019
@rugk rugk mentioned this issue Dec 23, 2019
Merged
@rugk rugk closed this as completed in 7f0dd18 Dec 23, 2019
@rugk rugk closed this as completed in #69 Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add dark mode for popup rugk/awesome-emoji-picker
1 participant
@rugk