Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to convert a string in the clipboard to QR #37

Closed
Wikinaut opened this issue Apr 22, 2018 · 10 comments
Closed

Option to convert a string in the clipboard to QR #37

Wikinaut opened this issue Apr 22, 2018 · 10 comments
Labels
enhancement New feature or request

Comments

@Wikinaut
Copy link

Sometimes I have the need to convert a part of the screen into a QR code. Perhaps you can add this.

At the moment I use the method of http://www.jsqr.de/encode.html and his Bookmarklet http://www.jsqr.de/bookmarklet.html (though you have to trust the fetched code in the bookmarklet).

@Wikinaut
Copy link
Author

Wikinaut commented Apr 22, 2018

Most often I want "tel:somenumbers" to be presented as QR code.

@rugk rugk changed the title [Suggestion] Add an option to convert a string in the clipboard to QR Add an option to convert a string in the clipboard to QR Apr 22, 2018
@rugk rugk added the enhancement New feature or request label Apr 22, 2018
@rugk rugk changed the title Add an option to convert a string in the clipboard to QR Option to convert a string in the clipboard to QR Apr 22, 2018
@rugk
Copy link
Owner

rugk commented Apr 22, 2018

Mhh, this would require a clipboard access permission. I am not really keen on adding many permissions for core functionality.
And BTW, to do so you can click on the QR code and can (if it works) instantly press Ctrl+V and the QR code is generated, so well… that is already easy (and similar to just typing text there).

But I have a better idea: What about #38? In addition that would be even one step less and no one needs a "generate from clipboard" butt0on or similar there.

(BTW this issue demonstrates that it is always important to write the core "problem" one has, respectively why/what one wants to accomplish. There may be better/alternative solution… Just a side-note.)

@Wikinaut
Copy link
Author

Wikinaut commented Apr 22, 2018

And BTW, to do so you can click on the QR code and can (if it works) instantly press Ctrl+V and the QR code is generated, so well… that is already easy (and similar to just typing text there).

I did not know that this works so perfectly...

@rugk
Copy link
Owner

rugk commented Apr 22, 2018

I did not know that this works so perfectly...

Okay, that kinda surprises me. Is the GUI not clear about that thing? Or why did you think does it display the URL again in the popup?

Just need to ask this in case this is a UX issue. If it is your own "fault", then this is better for me, of course, but just to be sure… 😉

@Wikinaut
Copy link
Author

Wikinaut commented Apr 22, 2018

Until now, I was only using the add-on to generate the current page url.

My UX thoughts were: the textual display of the Url is for "security", so that one can check whether the whole url including optional query string key/value pairs is taken... (I use QR codes since many years).
So that was fine already.

But only when the user deletes the url text field - you have to know, that you can delete it - you will see your help text. So it would perhaps be better to already (always) show the help text when the url text is shown!

When the url is deleted, the text is not necessarily needed, because the user then sees an empty field. But I don't want to be a nitpicker, the text can then be shown also,

I already noticed now that the text field is already marked, so that it can easily be deleted or modified.

@rugk
Copy link
Owner

rugk commented Apr 23, 2018

One more question: in what color is it marked for you? In what OS is that?
Because usually my thought was when the text is marked (selected) and the user sees that, they know they can press delete.
I could change the highlight color for that, if it helps.
Adding a string above or so wastes too much space and I want avoid that. The ui should be as simple, so that users intuitively know that this thing can be changed. No descriptive text should be needed in an ideal world.
(I also added the placeholder text rather because it looks better than an empty only field rather than for a real ux gain.)

@rugk
Copy link
Owner

rugk commented Apr 23, 2018

BTW this is not nitpicking at all, this is ux design.😉 Each detail matters.

@rugk
Copy link
Owner

rugk commented Apr 23, 2018

I have verified this issue with another add-on user and it seems to be not intuitive indeed. So I've created #42 for tracking this.

You can answer my questions there, if you want.

@Wikinaut
Copy link
Author

bildschirmfoto 2018-04-25 um 00 15 46

@rugk you asked about the colour:

Here's a screenshot how it looks on

  • macOS High Sierra 10.13.4
  • Firefox 59.0.2

@rugk
Copy link
Owner

rugk commented Apr 25, 2018

Ah okay, so auto-selecting works there, at least. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants