Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in FedProx loss computation #24

Closed
TsingZ0 opened this issue Jul 4, 2024 · 0 comments
Closed

Error in FedProx loss computation #24

TsingZ0 opened this issue Jul 4, 2024 · 0 comments

Comments

@TsingZ0
Copy link

TsingZ0 commented Jul 4, 2024

image

The summation of L2 losses over named_parameters() does not equal the L2 loss of the entire model. Please check fed_local_dpo.py and fed_local_sft.py
@TsingZ0 TsingZ0 closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TsingZ0