fix <a> with blank target by adding security options

stillbeben · Oct 31, 2017 · 03ddd38 · 03ddd38
1 parent 67bd45a
commit 03ddd38
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/templates/base.html b/templates/base.html
@@ -127,15 +127,15 @@ <h1><a href="{{ SITEURL }}">{{ SITETITLE }}</a></h1>
           {% endfor %}
 
           {% for name, link in LINKS %}
-          <li><a href="{{ link }}" target="_blank">{{ name }}</a></li>
+          <li><a href="{{ link }}" target="_blank" rel="noopener noreferrer">{{ name }}</a></li>
           {% endfor %}
         </ul>
       </nav>
       {% endif %}
 
       <ul class="social">
         {% for name, link in SOCIAL %}
-        <li><a class="sc-{{ name }}" href="{{ link }}" target="_blank"><i class="fa fa-{{ name }}"></i></a></li>
+        <li><a class="sc-{{ name }}" href="{{ link }}" target="_blank" rel="noopener noreferrer"><i class="fa fa-{{ name }}"></i></a></li>
         {% endfor %}
       </ul>
     </div>

diff --git a/templates/partial/cc_license.html b/templates/partial/cc_license.html
@@ -5,7 +5,8 @@
 <p>
   <a rel="license"
      href="http://creativecommons.org/licenses/{{ CC_LICENSE['slug'] }}/{{ CC_LICENSE['version'] }}/"
-     target="_blank">
+     target="_blank"
+     rel="noopener noreferrer">
     <img alt="Creative Commons License"
          title="Creative Commons License"
          style="border-width:0"

diff --git a/templates/partial/flex.html b/templates/partial/flex.html
@@ -1,6 +1,6 @@
 <p>{{ _('powered by %(pelican_url)s - %(flex_url)s theme by %(alexandrevicenzi_url)s - modified by %(ricoullmann_url)s - Source: %(flex_ricoullmann_url)s',
-  pelican_url='<a href="http://getpelican.com" target="_blank">Pelican</a>',
-  flex_url='<a href="https://github.com/alexandrevicenzi/flex" target="_blank">Flex</a>'|safe,
-  alexandrevicenzi_url='<a href="http://alexandrevicenzi.com" target="_blank">Alexandre Vicenzi</a>'|safe,
-  ricoullmann_url='<a href="https://erinnerungsfragmente.de" target="_blank">Rico Ullmann</a>'|safe,
-  flex_ricoullmann_url='<a href="https://erinnerungsfragmente.de" target="_blank">pelican-theme-flex</a>'|safe) }}</p>
+  pelican_url='<a href="http://getpelican.com" target="_blank" rel="noopener noreferrer">Pelican</a>',
+  flex_url='<a href="https://github.com/alexandrevicenzi/flex" target="_blank" rel="noopener noreferrer">Flex</a>'|safe,
+  alexandrevicenzi_url='<a href="http://alexandrevicenzi.com" target="_blank" rel="noopener noreferrer">Alexandre Vicenzi</a>'|safe,
+  ricoullmann_url='<a href="https://erinnerungsfragmente.de" target="_blank" rel="noopener noreferrer">Rico Ullmann</a>'|safe,
+  flex_ricoullmann_url='<a href="https://erinnerungsfragmente.de" target="_blank" rel="noopener noreferrer">pelican-theme-flex</a>'|safe) }}</p>