Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out why serde_json::Value can't be replaced by Box<serde_json::value::RawValue> everywhere #18

Closed
jplatte opened this issue May 5, 2020 · 4 comments
Closed

Figure out why serde_json::Value can't be replaced by Box<serde_json::value::RawValue> everywhere #18

jplatte opened this issue May 5, 2020 · 4 comments
Labels
effort/hard help wanted

Comments

@jplatte
Copy link
Member

jplatte commented May 5, 2020

… and possibly replace them with Box<serde_json::value::RawValue>.

serde_json::Value has mostly been replaced by Box<serde_json::value::RawValue>, but it doesn't seem to be working in BTreeMap<String, Value>. Needs further investigation.
@jplatte jplatte self-assigned this May 5, 2020
@jplatte

This comment has been minimized.

Sign in to view
@jplatte jplatte closed this as completed May 5, 2020
@jplatte
Copy link
Member Author

jplatte commented May 5, 2020

Whoops, didn't mean to close.

@jplatte jplatte reopened this May 5, 2020
@jplatte jplatte changed the title Review uses of serde_json::Value Figure out why serde_json::Value can't be replaced by Box<serde_json::value::RawValue> everywhere May 5, 2020
@jplatte jplatte transferred this issue from another repository Jun 5, 2020
@jplatte
Copy link
Member Author

jplatte commented Aug 4, 2020 •
edited

Maybe serde-rs/serde#1183.

EDIT: Probably not that exact thing but sth. similar. I expect there is no way for this to work, but if somebody wants to look into it, I would be interested in what you can find out!

@jplatte jplatte removed their assignment Sep 15, 2020
@jplatte
Copy link
Member Author

jplatte commented Feb 2, 2021

This isn't really actionable.

@jplatte jplatte closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hard help wanted
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jplatte