Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back ruma-events/tests/stripped.rs by updating existing file #50

Merged
merged 2 commits into from Jun 15, 2020

Conversation

DevinR528
Copy link
Member

No description provided.

@jplatte jplatte changed the title Adds back ruma-events/tests/stripped.rs by updating existing file Add back ruma-events/tests/stripped.rs by updating existing file Jun 13, 2020
@jplatte
Copy link
Member

jplatte commented Jun 13, 2020

It doesn't show in the log on web (there's a message at the start of the test build with a link to the full log), but there's some clippy warnings in the test you added back. Could you set up clippy locally to fix these? (in VSCode with RA, set "rust-analyzer.checkOnSave.command": "clippy")

@DevinR528
Copy link
Member Author

DevinR528 commented Jun 13, 2020

This is so weird I have not been able to reproduce any of these clippy warnings locally and I've been using rustc 1.46.0-nightly (feb3536eb 2020-06-09) and clippy 0.0.212 (feb3536 2020-06-09). rustup won't update from 2020-06-09 to 2020-06-12 for me either. Anyways I hope this works as I can't really test it but I fixed the errors from the full log.

Using the RA setting works perfectly though thanks for that!!

@jplatte jplatte merged commit 3ec0936 into ruma:master Jun 15, 2020
@DevinR528 DevinR528 deleted the stripped-tests branch May 3, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants