Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With v1.1, move module format to per-endpoint versioning #819

Closed
ShadowJonathan opened this issue Jan 18, 2022 · 3 comments
Closed

With v1.1, move module format to per-endpoint versioning #819

ShadowJonathan opened this issue Jan 18, 2022 · 3 comments

Comments

@ShadowJonathan
Copy link
Member

ShadowJonathan commented Jan 18, 2022

Basically, r0::sync::sync_events -> sync::sync_events::{v3, v4, ...}

This in accordance with Matrix's new Global Versioning, which moves to per-endpoint versioning.

This way, new endpoint versions can easily be added (v4 under the related module, like above) and maintained, instead of having to be in fluid accordance to sub-revisions.

"The matrix version that ruma supports" can then be further granularized, and "old versions" supported much more easily.

It could also open up some form of "specify the matrix versions you want" via crate features, which then define/undefine specific endpoints/versions/features by macros.

More info: https://spec.matrix.org/v1.1/#endpoint-versioning

@jplatte
Copy link
Member

jplatte commented Jan 18, 2022

Blocked on #792.

@zecakeh
Copy link
Contributor

zecakeh commented Jan 19, 2022

Isn't this the same as #775?

@jplatte
Copy link
Member

jplatte commented Jan 19, 2022

Yes, I'll close this as a duplicate.

@jplatte jplatte closed this as completed Jan 19, 2022
@jplatte jplatte removed this from the 0.6.0 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants