Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to k8s-service module #876

Closed
jocchionero opened this issue May 11, 2022 · 1 comment
Closed

Add features to k8s-service module #876

jocchionero opened this issue May 11, 2022 · 1 comment

Comments

@jocchionero
Copy link

What would you like to be added:

  1. Would like dashes allowed in k8-service module, current error is:
ERROR: Invalid module name, can only contain letters and numbers!
If you need more help please reach out to the contributors in our slack channel at: https://slack.opta.dev
  1. Would like to have custom health checks in same k8s-service module like in standard k8s yaml
  - name: my-service
    type: k8s-service
...
    livenessProbe:
      exec:
        command:
        - cat
        - /tmp/healthy
...

Why is this needed:

  1. This is a request from my team to stay consistent with current environments (pre opta migration)
  2. A request from my team to allow this while we create actual health-check endpoints AND for 3rd part containers where we do not control the code to expose endpoints

Extra info (e.g. existing slack convo link):

https://opta-group.slack.com/archives/C0240NBKUMT/p1652223456899139

@juandiegopalomino
Copy link
Collaborator

release is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants