Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Enabling Ingress Nginx Service-Upstream Annotation #914

Open
jocchionero opened this issue Jun 27, 2022 · 0 comments
Open

Allow Enabling Ingress Nginx Service-Upstream Annotation #914

jocchionero opened this issue Jun 27, 2022 · 0 comments

Comments

@jocchionero
Copy link

jocchionero commented Jun 27, 2022

What would you like to be added:

We would like to have the option to set the nginx.ingress.kubernetes.io/service-upstream annotation on ingress resources to "true". This would allow us to leverage linkerd's serviceprofiles to load balance and add some extra linkerd routing capabilities.

https://linkerd.io/2.11/tasks/using-ingress/#nginx

Why is this needed:

The annotation nginx.ingress.kubernetes.io/service-upstream: "true" is used to tell Nginx Ingress Controller to route traffic to the service of the meshed application instead of directly to the pods. By default, Ingress Controllers query the endpoints of their target service to retrieve the IP addresses of the pods behind the service. They route traffic to the pods directly. By sending traffic to the service, Linkerd features such as load balancing and traffic splitting are enabled. Only caveat being when you use the annotation above, you cannot have sticky sessions with cookie-based affinity--we fortunately are not concerned about sticky sessions, so enabling true for everyone could be opinionated.

Extra info (e.g. existing slack convo link):

Opta:
https://opta-group.slack.com/archives/C0240NBKUMT/p1656010415309269

Linkerd:
https://linkerd.slack.com/archives/C89RTCWJF/p1648220320987219?thread_ts=1648218339.750139&cid=C89RTCWJF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant