Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: PRs should be assigned a milestone upon merge #2978

Open
1 task
nitrocode opened this issue Jan 13, 2023 · 0 comments
Open
1 task

build: PRs should be assigned a milestone upon merge #2978

nitrocode opened this issue Jan 13, 2023 · 0 comments
Labels
build Relating to how we build Atlantis feature New functionality/enhancement

Comments

@nitrocode
Copy link
Member

nitrocode commented Jan 13, 2023

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

It would be nice to assign the milestone of the next release upon merging a PR

The benefit of this would be that maintainers would no longer need to

  • manually set the milestone prior to merging
  • backfill milestones using issue filter logic
    • e.g. is:pr is:merged no:milestone merged:2022-10-05..2022-11-28
    • where 2022-10-05 and 2022-11-28 are the dates of releases

This will also remove errors in assigning milestones.

Another benefit is that we will be able to always know which PR is in which release. If there is ever an issue, it will be that much easier to triage.

Describe the solution you'd like

It would be great if goreleaser did this out of the box.

If not, then we'd need a github action that

  • runs on PR merge
  • checks if there is a milestone on the PR
  • if so, do nothing
  • if not
    • detects the most recent open milestone name
    • applies the milestone to recently merged PR

Looks like the terraform aws provider project does this

If you look at how they implement it, it looks like

https://github.com/hashicorp/terraform-provider-aws/blob/main/.github/workflows/milestone.yml

  • they add the current milestone as a header at the top of the CHANGELOG
  • then milestone.yml will
    • get that milestone name
    • get the milestone number from the name
    • use the breathingdust action to set the milestone on the closed (merged) pr

Describe the drawbacks of your solution

Describe alternatives you've considered

@nitrocode nitrocode added feature New functionality/enhancement build Relating to how we build Atlantis labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Relating to how we build Atlantis feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant