Atlantis erroring on self when commands are run on closed PRs

[wyardley]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

Possible regression of #533
When running a command on a closed pull request, Atlantis seems to error on its own command with
Error parsing command: EOF found when expecting closing quote

Reproduction Steps

1. Run atlantis plan

Logs

Logs

{
  "insertId": "dskqyz7hf6wgdbhr",
  "jsonPayload": {
    "ts": "2023-06-28T18:02:41.150Z",
    "level": "info",
    "msg": "command was run on closed pull request",
    "caller": "events/command_runner.go:409",
    "json": {
      "repo": "xxx/yyy",
      "pull": "2087"
    }
  },
  "resource": {
    "type": "k8s_container",
    "labels": {
      "location": "us-west2",
      "pod_name": "atlantis-0",
      "project_id": "xx",
      "namespace_name": "atlantis",
      "cluster_name": "infra-cluster-01",
      "container_name": "atlantis"
    }
  },
  "timestamp": "2023-06-28T18:02:41.150929969Z",
  "severity": "INFO",
  "labels": {
    "compute.googleapis.com/resource_name": "gke-infra-cluster-01-default-node-poo-37d84d77-8qqr",
    "k8s-pod/statefulset_kubernetes_io/pod-name": "atlantis-0",
    "k8s-pod/app": "atlantis",
    "k8s-pod/controller-revision-hash": "atlantis-6fdf9d5cb7"
  },
  "logName": "projects/xxx/logs/stderr",
  "receiveTimestamp": "2023-06-28T18:02:43.480767837Z"
}
{
  "insertId": "8ofssrzueseixwub",
  "jsonPayload": {
    "ts": "2023-06-28T18:02:42.472Z",
    "level": "info",
    "caller": "events/events_controller.go:549",
    "json": {
      "gh-request-id": "X-Github-Delivery=f9bccdc0-15dd-11ee-9556-84ca52f9d5ee"
    },
    "msg": "parsed comment as <nil>"
  },
  "resource": {
    "type": "k8s_container",
    "labels": {
      "location": "us-west2",
      "container_name": "atlantis",
      "cluster_name": "infra-cluster-01",
      "pod_name": "atlantis-0",
      "namespace_name": "atlantis",
      "project_id": "xxx"
    }
  },
  "timestamp": "2023-06-28T18:02:42.472837417Z",
  "severity": "INFO",
  "labels": {
    "compute.googleapis.com/resource_name": "gke-infra-cluster-01-default-node-poo-37d84d77-8qqr",
    "k8s-pod/controller-revision-hash": "atlantis-6fdf9d5cb7",
    "k8s-pod/statefulset_kubernetes_io/pod-name": "atlantis-0",
    "k8s-pod/app": "atlantis"
  },
  "logName": "projects/xxx/logs/stderr",
  "receiveTimestamp": "2023-06-28T18:02:43.480767837Z"
}

Environment details

• Atlantis version: v0.24.3
• Deployment method: GCS (via Flux)
• If not running the latest Atlantis version have you tried to reproduce this issue on the latest version:
• Atlantis flags: server

Atlantis server-side config file:
let us know if you need more config details

Repo atlantis.yaml file:
let us know if you need more details

Additional Context

[wyardley]

We disabled autoplan globally, which, from my perspective, at least, is Good Enough (TM)