Disabling emoji reactions doesn't work

[dpedu]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

I have set --emoji-reaction="" on the cli and emoji-reaction: "" in the config, but Atlantis 0.27.2 still does emoji reactions on github enterprise.

Reproduction Steps

1. Set the options described above
2. Comment atlantis plan on a PR
3. See that it reacts anyway

Logs

The New Issue instruction said to use atlantis plan --debug, but atlantis replies to this saying Error: unknown flag: --debug. I tried with --verbose, which is valid, but the logs looked too sensitive to post. In any case, the words "react" or "emoji" don't appear in them...

The server-side logs show items like:

{"level":"debug","ts":"2024-03-14T22:58:52.580Z","caller":"metrics/debug.go:42","msg":"counter","json":{"name":"atlantis.github.react_to_comment.execution_success","value":1,"tags":{},"type":"counter"}}

Environment details

• Atlantis version: 0.27.2
• Deployment method: docker
• Atlantis flags: -config=/etc/atlantis.yml --repo-config=/etc/repos.yml --emoji-reaction=

Atlantis server-side config file:

version: 3
port: 8080
automerge: true
gh-hostname: private
gh-user: private
repo-allowlist: private
atlantis-url: https://private/
log-level: debug
write-git-creds: true
hide-prev-plan-comments: true
allow-draft-prs: true
enable-diff-markdown-format: true
emoji-reaction: ""
use-tf-plugin-cache: true

Repo atlantis.yaml file:

This is an example:

- name: private
  dir: private
  workflow: private
  terraform_version: private
  autoplan:
    when_modified:
    - '**/**'

Additional Context

I've seen it mentioned that disabling it is only meant to work for nick plan/apply style comments (no @). I'm using that form.

[CaioAugustoo]

I don't believe this is a bug but intentional. As you can see in cmd/server.go at line 853, flag emoji-reaction='' actually does not disable emojis but set to the default (eyes emoji).

I believe that we should have a disable-emoji-reaction flag. Something like ... -config=/etc/atlantis.yml --repo-config=/etc/repos.yml --disable-emoji-reaction

If anyone thinks this is a good feature I would like to develop it.

[dpedu]

From #3360 it sounds like this should work. Maybe it broke or was backed out at some point, that I don't know.

Looks like this is a dupe as well: #3457

[nitrocode]

Thanks @dpedu. Closing because it's a duplicate. Let's discuss in the original issue #3457.