Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis posts Bitbucket token when there is a connection error #615

Closed
kipkoan opened this issue May 4, 2019 · 1 comment · Fixed by #618
Closed

Atlantis posts Bitbucket token when there is a connection error #615

kipkoan opened this issue May 4, 2019 · 1 comment · Fixed by #618
Labels
bug Something isn't working provider/bitbucket

Comments

@kipkoan
Copy link
Contributor

kipkoan commented May 4, 2019

We had a brief network blip that caused Atlantis to not be able to connect to our Bitbucket server.

Atlantis then commented on the PR, and that comment included the full Bitbucket token:

fatal: unable to access 'https://atlantis:LfKycJ4Wmx8HJH5eWCdWExKm9v2SmHWwwS8NWXpkzkC5@bitbucket.example.com/scm/anatf/my-repository.git/': OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to bitbucket.example.com:443 
: exit status 128

Expected: Atlantis should redact the token and not post it in a PR comment.

(Note: that is not the real token we are using... I generated a new one for demonstration.)

@lkysow lkysow added the bug Something isn't working label May 4, 2019
@lkysow
Copy link
Member

lkysow commented May 7, 2019

Fixed in 0.7.2. Thanks for the report, that wasn't good!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider/bitbucket
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants