Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo whitelist globbing ignores everything after #692

Closed
walkamongus opened this issue Jun 26, 2019 · 1 comment · Fixed by #796
Closed

repo whitelist globbing ignores everything after #692

walkamongus opened this issue Jun 26, 2019 · 1 comment · Fixed by #796
Assignees
@dedamico
Labels
bug Something isn't working help wanted Good feature for contributors

Comments

@walkamongus
Copy link

During testing, I've noticed that if I use globbing in repo names, everything after the glob is ignored.

If I use something like github.com/myorg/myrepo-* it works as expected.

However, if I add github.com/myorg/*-myrepo all repos in the org are allowed.
@lkysow lkysow added the question Further information is requested label Jun 26, 2019
@lkysow
Copy link
Member

lkysow commented Jun 26, 2019 •
edited

Yes this is intended. The * matches everything.

Edit: Sorry, you're right this looks to be a bug.

@lkysow lkysow added bug Something isn't working and removed question Further information is requested labels Jun 26, 2019
@lkysow lkysow added the help wanted Good feature for contributors label Jul 24, 2019
@dedamico dedamico self-assigned this Sep 30, 2019
@dedamico dedamico mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dedamico dedamico

Labels
bug Something isn't working help wanted Good feature for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to allow whitelist globbing for strings after wildcard runatlantis/atlantis
3 participants
@lkysow @walkamongus @dedamico