Remove parameter states from execution state API #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove parameterStates (fix rundeck#2268) This brings it in line with: http://rundeck.org/docs/api/index.html#execution-state - Add API tests for execution state call
|
I think the correct fix is to massage the map data to produce valid xml when converted. However I don't know if anyone uses |
|
@gschueler I thought that... I attempted to coerce it into a valid structure but couldn't quite get it right first time. If I can find some time I will have another look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #2268
@gschueler I wasn't sure if
parameterStateswas intended to be returned by this API call, the documentation at: http://rundeck.org/docs/api/index.html#execution-state doesn't reference it. If you think it should be returned, then I can rework this.