Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted popping/re-pushing when on navigation coordinator #22

Closed
jblanco-applaudostudios opened this issue Sep 6, 2021 · 3 comments
Closed

Comments

@jblanco-applaudostudios
Copy link

Hello, I'm having an issue with the navigation stacks. I have a SidebarCoordinator that has a SplitviewCoordinator inside of it (both are custom coordinators I made). The SplitviewCoordinator shows two NavigationCoordinators side by side.

I'm having a problem that whenever I show or hide the sidebar, if any of the navigation stacks is not on the root it will pop and then re-push the current view on said stack. Is this a known issue? Or perhaps a mistake I made while coding the coordinator view?

@jblanco-applaudostudios jblanco-applaudostudios changed the title Unwanting popping/re-pushing when on navigation coordinator Unwanted popping/re-pushing when on navigation coordinator Sep 6, 2021
@rundfunk47
Copy link
Owner

Hi! Can't say I've really noticed that before no. Would it be possible for you to reproduce the issue in a small example app where I can see what's happening?

@rundfunk47
Copy link
Owner

Hi! There's a version 2.0.0 now that relies on isActive instead of onAppear to set the navigation stack, which I suspect might have been the cause of the issue. Please try it and see if it resolves it!

@jblanco-applaudostudios
Copy link
Author

Thanks, I'm working on migrating to 2.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants